javascript help/advice - dealing with tables and eval()

[alexmcclune]

Hi,

I have a form with the usual fields (name, address, details, etc) and this content is saved into a table as name/value pairs. I would then like to repopulate the form at a later date using the name/value pairs to match the content up to the correct form fields.

I have the following code, array just seemed like a sensible choice to easily manage the fields (and I want to re-use the code on other forms).

Code: Select all

var meta_rows = tables.TBL_META.fetchTable();
var fieldsarray = new Array();
fieldsarray[0] = "FRM_TITLE";
fieldsarray[1] = "FRM_FIRSTNAME";
fieldsarray[2] = "FRM_LASTNAME";
fieldsarray[3] = "FRM_ADDRESS1";
fieldsarray[4] = "FRM_ADDRESS2";
fieldsarray[5] = "FRM_ADDRESS3";
fieldsarray[6] = "FRM_ADDRESS4";
fieldsarray[7] = "FRM_POSTCODE";
fieldsarray[8] = "FRM_TELEPHONE";
fieldsarray[9] = "FRM_EMAIL";
fieldsarray[10] = "FRM_DETAILS";
fieldsarray[11] = "FRM_DETAILS_MORE";
fieldsarray[12] = "FRM_OTHER_DETAILS";

while (meta_rows.next()){
	if ( system.executeCustomFunction("contains", [tables.TBL_META.FLD_ID.value, "FRM_"])){
		if ( tables.TBL_META.FLD_STRING_ID.value == 0 ){
			for &#40;var i=0; i < fieldsarray.length; i++&#41;&#123;
					var fieldname = "fields."+fieldsarray&#91;i&#93;+".value";	
				if &#40; tables.TBL_META.FLD_ID.value == fieldsarray&#91;i&#93; &#41;&#123;
					var x = fieldname + "='" + tables.TBL_TESTCRM_PPCALLMETADATA.FLD_VAL.value + "';";
					eval&#40;'x'&#41;;
				&#125;
			&#125;
		&#125; // somethig else here
	&#125;
&#125;

EDIT - I have managed to get around all my errors but unfortunately the form does not populate. When I log the value of "x" it is in the correct format but the eval() does not execute it - the form fields are not set.

Please forgive any coding bad practice, I am pretty damn new to Javascript so learning as I go.

[dvanhussel]

Hi,

I think that because you have x within '', it is evaluated as a string, not as the value of the var.

I think this will work:

Code: Select all

var x = '\''+fieldname+'='+tables.TBL_TESTCRM_PPCALLMETADATA.FLD_VAL.value+'\'';
eval(x);

But, why do want to do it like this?

If you map the form fields to the corresponding fields of the database resource, you only have to fetch it to populate the form fields with the correct data.

[Jon]

I think it should be

Code: Select all

eval(x);

instead of

Code: Select all

eval('x');

P.S. instead of using the FPL contains function, you can do:

Code: Select all

if (tables.TBL_META.FLD_ID.value && tables.TBL_META.FLD_ID.value.indexOf("FRM_") != -1)
..

The first part of this checks for a null value and the second part does the contains check. It will be much faster.

Regards
Jon

[alexmcclune]

Thanks, I have got it working now - using too many "'" and you were right jon, the 'x' was incorrect. Many thanks.

The database table I am grabbing data from essentially has 3 fields (although in reality it has more and I am grabbing data from 2 tables with similar structure - only 1 will be populated).

Anyway the table has 3 fields, a call_id, the field_ID and the Field Value:
- call id is a unique reference
- field_id is the form_field name
- field_val is the form_field value

Can you think of a way to map that resource to a form with numerous fields (of which the only way to determine the content is by comparing the form field name to the value of field_id in the table)?

I briefly tried and couldn't see an obvious method, I created the javascript as the solution but if there is an easier way I would love to hear it?

[Jon]

I don't think there's an easier way. If I was doing this I would code the SQL statement in the Javascript then find each field dynamically using fields.getField(xxx). Probably the way you've done it by the sound of it.